Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONT REVIEW] Begin implementation of schema processor #8344

Closed
wants to merge 5 commits into from
Closed

[DONT REVIEW] Begin implementation of schema processor #8344

wants to merge 5 commits into from

Conversation

tigrannajaryan
Copy link
Member

This is the first draft PR of a processor that implements schema transformations. This is not ready for review.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/schema-processor branch from bc3b3dd to f01d14a Compare March 8, 2022 16:33
@tigrannajaryan
Copy link
Member Author

Hi @MovieStoreGuy! @tedsuo told me today that you wanted to help with implementing the schema processor in the Collector. I started the implementation but will be leaving for vacation in 2 days, so won't be able to finish this quickly.
Are you interested in taking this draft over? I also have an example code that does the actual transformations here https://github.com/tigrannajaryan/telemetry-schema

@MovieStoreGuy
Copy link
Contributor

Yeah, happy to take this over :)

I do have a different approach to this though on a local branch on my machine but I think I can merge the two ideas together.

@tigrannajaryan
Copy link
Member Author

Yeah, happy to take this over :)

I do have a different approach to this though on a local branch on my machine but I think I can merge the two ideas together.

Sounds good. If you publish anything by tomorrow morning I may be able to comment before I leave.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy will be requested when the pull request is marked ready for review MovieStoreGuy is a code owner

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tigrannajaryan @MovieStoreGuy